Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ember/test-helpers v4 as peerDependency #9525

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Aug 27, 2024

This PR allows consumer apps also @ember/test-helpers v4 version (test-helper is now a v2 addon)

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 1, 2024

@runspired can we get a review also for this one?

@Baltazore
Copy link
Collaborator

@runspired I don't really understand why tests are failing on master. Preston mentioned it might pick up wrong version of test helpers.

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 21, 2024

The reason why it was still using v3.x of test-helper is, that there is a override in package.json and a patch for v3... Its not so nice to make a patch for a active addon which is provided from ember team.

I have now created a new patch for test-helper v4 and updated on all points to v4.

After this change, we were running into ember-cli-fastboot-testing error with test-helper, because there is missing the peerDependency (opend a issue embermap/ember-cli-fastboot-testing#872)

Preston has told me, that its possible fixed with updating all @embroider & auto-import versions to latest, but it wasn't... so i have added a patch for now

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 24, 2024

ember-cli-fastboot-testing has added now peerDependency of @ember/test-helper. Patching ember-cli-fastboot-testing is now not anymore necessary (already changes in this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: needs triage
Development

Successfully merging this pull request may close these issues.

3 participants